Skip to content

[Link in FlowController] Consumes backend linkSettings and removes client flag #10891

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 5 commits into
base: master
Choose a base branch
from
Open

[Link in FlowController] Consumes backend linkSettings and removes client flag #10891

wants to merge 5 commits into from

Conversation

carlosmuvi-stripe
Copy link
Collaborator

@carlosmuvi-stripe carlosmuvi-stripe commented May 30, 2025 •
edited
Loading

Summary

  • Deletes LinkProminenceFeatureProvider and uses LinkGate to provide the RUX in FlowController enablement.
  • Deletes local feature flag.
  • Consumes backend feature flag.

Motivation

Testing

  • Added tests
  • Modified tests
  • Manually verified

Screenshots

Before After
before screenshot after screenshot

Changelog

@carlosmuvi-stripe carlosmuvi-stripe force-pushed the carlosmuvi/remove-client-flag branch from 2928d2a to 632c077 Compare May 30, 2025 22:39
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented May 30, 2025 •
edited
Loading

Diffuse output:

OLD: paymentsheet-example-release-master.apk (signature: V1, V2)
NEW: paymentsheet-example-release-pr.apk (signature: V1, V2)

          │            compressed            │           uncompressed           
          ├───────────┬───────────┬──────────┼───────────┬───────────┬──────────
 APK      │ old       │ new       │ diff     │ old       │ new       │ diff     
──────────┼───────────┼───────────┼──────────┼───────────┼───────────┼──────────
      dex │   4.4 MiB │   4.4 MiB │ +2.3 KiB │   9.6 MiB │   9.6 MiB │ +1.5 KiB 
     arsc │   2.5 MiB │   2.5 MiB │      0 B │   2.5 MiB │   2.5 MiB │      0 B 
 manifest │   5.6 KiB │   5.6 KiB │      0 B │  28.7 KiB │  28.7 KiB │      0 B 
      res │ 912.3 KiB │ 912.3 KiB │      0 B │   1.4 MiB │   1.4 MiB │      0 B 
   native │   3.5 MiB │   3.5 MiB │      0 B │   8.5 MiB │   8.5 MiB │      0 B 
    asset │   1.6 MiB │   1.6 MiB │ -1.5 KiB │   1.6 MiB │   1.6 MiB │ -1.5 KiB 
    other │ 197.2 KiB │ 197.2 KiB │     +2 B │ 372.4 KiB │ 372.4 KiB │      0 B 
──────────┼───────────┼───────────┼──────────┼───────────┼───────────┼──────────
    total │  13.1 MiB │  13.1 MiB │   +920 B │  24.1 MiB │  24.1 MiB │    +83 B 

         │         raw          │               unique                
         ├───────┬───────┬──────┼───────┬───────┬─────────────────────
 DEX     │ old   │ new   │ diff │ old   │ new   │ diff                
─────────┼───────┼───────┼──────┼───────┼───────┼─────────────────────
   files │     2 │     2 │    0 │       │       │                     
 strings │ 46763 │ 46830 │  +67 │ 45840 │ 45856 │ +16 (+2981 -2965)   
   types │ 16545 │ 16587 │  +42 │ 16106 │ 16106 │   0 (+2958 -2958)   
 classes │ 13596 │ 13596 │    0 │ 13596 │ 13596 │   0 (+2321 -2321)   
 methods │ 67052 │ 67051 │   -1 │ 66473 │ 66480 │  +7 (+20564 -20557) 
  fields │ 44590 │ 44606 │  +16 │ 44368 │ 44370 │  +2 (+15631 -15629) 

 ARSC    │ old  │ new  │ diff 
─────────┼──────┼──────┼──────
 configs │  242 │  242 │  0   
 entries │ 6311 │ 6311 │  0
APK 
     compressed      │     uncompressed     │                                           
──────────┬──────────┼───────────┬──────────┤                                           
 size     │ diff     │ size      │ diff     │ path                                      
──────────┼──────────┼───────────┼──────────┼───────────────────────────────────────────
  4.3 MiB │ +1.6 KiB │   9.5 MiB │   +140 B │ ∆ classes.dex                             
  6.9 KiB │ -1.4 KiB │   6.8 KiB │ -1.4 KiB │ ∆ assets/dexopt/baseline.prof             
 62.5 KiB │   +735 B │ 146.5 KiB │ +1.4 KiB │ ∆ classes2.dex                            
    127 B │   +127 B │       5 B │     +5 B │ + META-INF/services/da.x                  
    127 B │   +127 B │       5 B │     +5 B │ + META-INF/services/ea.a                  
          │   -127 B │           │     -5 B │ - META-INF/services/ea.x                  
          │   -127 B │           │     -5 B │ - META-INF/services/fa.a                  
    1 KiB │    -12 B │     942 B │    -12 B │ ∆ assets/dexopt/baseline.profm            
 54.5 KiB │     +2 B │ 120.9 KiB │      0 B │ ∆ META-INF/CERT.SF                        
   51 KiB │     -2 B │ 120.9 KiB │      0 B │ ∆ META-INF/MANIFEST.MF                    
    272 B │     +1 B │     120 B │      0 B │ ∆ META-INF/version-control-info.textproto 
    240 B │     -1 B │     101 B │      0 B │ ∆ assets/sentry-debug-meta.properties     
  1.2 KiB │     +1 B │   1.2 KiB │      0 B │ ∆ META-INF/CERT.RSA                       
──────────┼──────────┼───────────┼──────────┼───────────────────────────────────────────
  4.5 MiB │   +920 B │   9.9 MiB │    +83 B │ (total)
DEX 
STRINGS:

   old   │ new   │ diff              
  ───────┼───────┼───────────────────
   45840 │ 45856 │ +16 (+2981 -2965) 
  
  + , disableLinkRuxInFlowController=
  + , disableRuxInFlowController=
  + A1
  + B1
  + C1
  + D1
  + E1
  + F1
  + G1
  + LA7/e;
  + LA7/f;
  + LA7/g;
  + LA7/h;
  + LA7/i;
  + LA9/a;
  + LA9/b;
  + LA9/c;
  + LA9/d;
  + LA9/e;
  + LA9/f;
  + LA9/g;
  + LA9/h;
  + LA9/i;
  + LA9/j;
  + LA9/k;
  + LA9/l;
  + LA9/m;
  + LA9/n;
  + LA9/o;
  + LA9/p;
  + LA9/q;
  + LA9/r;
  + LA9/s;
  + LA9/t;
  + LA9/u;
  + LA9/v;
  + LB6/v0;
  + LB7/j;
  + LB7/k;
  + LB7/l;
  + LB7/m;
  + LB7/n;
  + LB7/o;
  + LB7/p;
  + LB7/q;
  + LB7/r;
  + LB8/g;
  + LB9/s;
  + LB9/t;
  + LB9/u;
  + LD/a1;
  + LD9/A;
  + LD9/B;
  + LD9/C;
  + LD9/D;
  + LD9/E;
  + LD9/F;
  + LD9/G;
  + LD9/H;
  + LD9/I;
  + LD9/J;
  + LD9/K;
  + LD9/L;
  + LD9/M;
  + LD9/N;
  + LD9/O;
  + LD9/P;
  + LD9/Q;
  + LD9/S;
  + LD9/T;
  + LD9/U;
  + LD9/V;
  + LD9/W;
  + LD9/X;
  + LD9/Y;
  + LD9/Z;
  + LD9/a0;
  + LD9/a;
  + LD9/b0;
  + LD9/b;
  + LD9/c0;
  + LD9/c;
  + LD9/d0;
  + LD9/d;
  + LD9/e0;
  + LD9/e;
  + LD9/f0;
  + LD9/f;
  + LD9/g0;
  + LD9/g;
  + LD9/h0;
  + LD9/h;
  + LD9/i0;
  + LD9/i;
  + LD9/j0;
  + LD9/j;
  + LD9/k0;
  + LD9/k;
  + LD9/l0;
  + LD9/l;
  + LD9/m0;
  + LD9/m;
  + LD9/n0;
  + LD9/n;
  + LD9/o0;
  + LD9/o;
  + LD9/p0;
  + LD9/p;
  + LD9/q0;
  + LD9/q;
  + LD9/r0;
  + LD9/r;
  + LD9/s0;
  + LD9/s;
  + LD9/t0;
  + LD9/t;
  + LD9/u0;
  + LD9/u;
  + LD9/v0;
  + LD9/v;
  + LD9/w0;
  + LD9/w;
  + LD9/x0;
  + LD9/x;
  + LD9/y0;
  + LD9/y;
  + LD9/z0;
  + LD9/z;
  + LE7/g;
  + LE7/h;
  + LE7/i;
  + LE7/j;
  + LE7/k;
  + LE7/l;
  + LE7/m;
  + LE7/n;
  + LE7/o;
  + LE7/p;
  + LE7/q;
  + LE7/r;
  + LE8/a;
  + LE8/b;
  + LE8/c;
  + LE8/d;
  + LE8/e;
  + LE8/f;
  + LE8/g;
  + LE8/h;
  + LE8/i;
  + LE8/j;
  + LE8/k;
  + LE8/l;
  + LE8/m;
  + LE8/n;
  + LE8/o;
  + LE8/p;
  + LE8/q;
  + LE8/r;
  + LE8/s;
  + LE8/t;
  + LE8/u;
  + LE8/v;
  + LF5/o;
  + LF7/r;
  + LF7/s;
  + LF7/t;
  + LF7/u;
  + LG9/b;
  + LG9/c;
  + LG9/d;
  + LG9/e;
  + LG9/f;
  + LG9/g;
  + LG9/h;
  + LG9/i;
  + LH6/b;
  + LH6/c;
  + LH6/d;
  + LH6/e;
  + LH8/h;
  + LI7/A;
  + LI7/B;
  + LI7/C;
  + LI7/D;
  + LI7/E;
  + LI7/c;
  + LI7/d;
  + LI7/e;
  + LI7/f;
  + LI7/g;
  + LI7/h;
  + LI7/i;
  + LI7/j;
  + LI7/k;
  + LI7/l;
  + LI7/m;
  + LI7/n;
  + LI7/o;
  + LI7/p;
  + LI7/q;
  + LI7/r;
  + LI7/s;
  + LI7/t;
  + LI7/u;
  + LI7/v;
  + LI7/w;
  + LI7/x;
  + LI7/y;
  + LI7/z;
  + LI9/b;
  + LI9/c;
  + LI9/d;
  + LJ6/d;
  + LJ6/e;
  + LJ6/f;
  + LJ6/g;
  + LJ6/h;
  + LJ6/i;
  + LJ6/j;
  + LJ6/k;
  + LJ6/l;
  + LJ6/m;
  + LJ6/n;
  + LJ6/o;
  + LJ6/p;
  + LJ6/q;
  + LJ6/r;
  + LJ6/s;
  + LJ6/t;
  + LJ6/u;
  + LJ6/v;
  + LJ6/w;
  + LJ6/x;
  + LJ6/y;
  + LJ7/A0;
  + LJ7/A1;
  + LJ7/B0;
  + LJ7/B1;
  + LJ7/C0;
  + LJ7/C1;
  + LJ7/D0;
  + LJ7/D1;
  + LJ7/E0;
  + LJ7/E1;
  + LJ7/E;
  + LJ7/F0;
  + LJ7/F1;
  + LJ7/F;
  + LJ7/G0;
  + LJ7/G1;
  + LJ7/G;
  + LJ7/H0;
  + LJ7/H1;
  + LJ7/H;
  + LJ7/I0;
  + LJ7/I1;
  + LJ7/I;
  + LJ7/J0;
  + LJ7/J1;
  + LJ7/J;
  + LJ7/K0;
  + LJ7/K1;
  + LJ7/K;
  + LJ7/L0;
  + LJ7/L1;
  + LJ7/L;
  + LJ7/M0;
  + LJ7/M1;
  + LJ7/M;
  + LJ7/N0;
  + LJ7/N1;
  + LJ7/N;
  + LJ7/O0;
  + LJ7/O1;
  + LJ7/O;
  + LJ7/P0;
  + LJ7/P1;
  + LJ7/P;
  + LJ7/Q0;
  + LJ7/Q1;
  + LJ7/Q;
  + LJ7/R0;
  + LJ7/R1;
  + LJ7/S0;
  + LJ7/S1;
  + LJ7/S;
  + LJ7/T0;
  + LJ7/T1;
  + LJ7/T;
  + LJ7/U0;
  + LJ7/U1;
  + LJ7/U;
  + LJ7/V0;
  + LJ7/V1;
  + LJ7/V;
  + LJ7/W0;
  + LJ7/W1;
  + LJ7/W;
  + LJ7/X0;
  + LJ7/X1;
  + LJ7/X;
  + LJ7/Y0;
  + LJ7/Y1;
  + LJ7/Y;
  + LJ7/Z0;
  + LJ7/Z1;
  + LJ7/Z;
  + LJ7/a0;
  + LJ7/a1;
  + LJ7/a2;
  + LJ7/b0;
  + LJ7/b1;
  + LJ7/b2;
  + LJ7/c0;
  + LJ7/c1;
  + LJ7/c2;
  + LJ7/d0;
  + LJ7/d1;
  + LJ7/d2;
  + LJ7/e0;
  + LJ7/e1;
  + LJ7/e2;
  + LJ7/f0;
  + LJ7/f1;
  + LJ7/f2;
  + LJ7/g0;
  + LJ7/g1;
  + LJ7/g2;
  + LJ7/h0;
  + LJ7/h1;
  + LJ7/h2;
  + LJ7/i0;
  + LJ7/i1;
  + LJ7/i2;
  + LJ7/j0;
  + LJ7/j1;
  + LJ7/j2;
  + LJ7/k0;
  + LJ7/k1;
  + LJ7/k2;
  + LJ7/l0;
  + LJ7/l1;
  + LJ7/l2;
  + LJ7/m0;
  + LJ7/m1;
  + LJ7/m2;
  + LJ7/n0;
  + LJ7/n1;
  + LJ7/n2;
  + LJ7/o0;
  + LJ7/o1;
  + LJ7/o2;
  + LJ7/p0;
  + LJ7/p1;
  + LJ7/p2;
  + LJ7/q0;
  + LJ7/q1;
  + LJ7/q2;
  + LJ7/r0;
  + LJ7/r1;
  + LJ7/r2;
  + LJ7/s0;
  + LJ7/s1;
  + LJ7/s2;
  + LJ7/t0;
  + LJ7/t1;
  + LJ7/t2;
  + LJ7/u0;
  + LJ7/u1;
  + LJ7/v0;
  + LJ7/v1;
  + LJ7/w0;
  + LJ7/w1;
  + LJ7/x0;
  + LJ7/x1;
  + LJ7/y0;
  + LJ7/y1;
  + LJ7/z0;
  + LJ7/z1;
  + LJ8/A;
  + LJ8/B;
  + LJ8/C
...✂

@carlosmuvi-stripe carlosmuvi-stripe force-pushed the carlosmuvi/remove-client-flag branch from 4873545 to ef1f31a Compare May 30, 2025 23:07
carlosmuvi-stripe
carlosmuvi-stripe commented May 30, 2025
View reviewed changes
paymentsheet/src/main/java/com/stripe/android/link/gate/LinkGate.kt
Comment on lines +5 to +9
/**
* Provider interface for Link feature settings and behaviors, handling
* the logic for determining when to show special Link UI elements or trigger automatic
* behaviors to enhance the Link payment experience.
*/
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Initially missed this class and then created LinkProminenceFeatureProvider. Deleted the latter and added docs to LinkGate so this doesn't happen to others in the future.

@carlosmuvi-stripe carlosmuvi-stripe marked this pull request as ready for review May 30, 2025 23:10
@carlosmuvi-stripe carlosmuvi-stripe requested review from a team as code owners May 30, 2025 23:10
@carlosmuvi-stripe carlosmuvi-stripe enabled auto-merge (squash) June 4, 2025 19:52
tillh-stripe
tillh-stripe reviewed Jun 4, 2025
View reviewed changes
@carlosmuvi-stripe carlosmuvi-stripe changed the title [Link in FlowController] Consumes backend linkSettings and removes client flag POC - Inline 2FA Jun 4, 2025
@carlosmuvi-stripe carlosmuvi-stripe changed the title POC - Inline 2FA [Link in FlowController] Consumes backend linkSettings and removes client flag Jun 4, 2025
@tillh-stripe tillh-stripe force-pushed the carlosmuvi/remove-client-flag branch from 83b3620 to 71a8b64 Compare June 13, 2025 20:45
samer-stripe
samer-stripe previously approved these changes Jun 13, 2025
View reviewed changes
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tillh-stripe tillh-stripe tillh-stripe left review comments

@samer-stripe samer-stripe samer-stripe left review comments

@cttsai-stripe cttsai-stripe Awaiting requested review from cttsai-stripe cttsai-stripe is a code owner automatically assigned from stripe/android-payments-reviewers

At least 1 approving review is required to merge this pull request.

Assignees

@tillh-stripe tillh-stripe

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@carlosmuvi-stripe @tillh-stripe @samer-stripe